refactor(resolver): remove unused proto fields and messages #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip proto definitions to only fields used by the resolver. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Segment,Flag,Variant,Rule,Client,ClientCredentialto only fields actually used by the resolverBundle Size Impact
The size reduction is modest because:
Deleted Files
confidence/flags/admin/v1/api.protoconfidence/flags/admin/v1/events/events.protoconfidence/flags/admin/v1/events/events_internal.protoconfidence/iam/v1/api.protoconfidence/iam/v1/auth_api.protoconfidence/iam/v1/events/events.protogoogle/type/decimal.protoTest plan
cargo buildpassescargo test --libpasses (100 tests)docker build .passes (all providers)🤖 Generated with Claude Code