Mark non-test classes with __test__ = False attribute #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves few warnings that were emitted by pytest.
Contributor
cecyliaborek
left a comment
cecyliaborek
left a comment
There was a problem hiding this comment.
lgtm 👍
just wondering, any reason why you chose to use __test__ = False instead of renaming those non-test classes? e.g. SearchCommandFixture instead of TestSearchCommand. That could be a better self-documentation of the code
Comment on lines
103
to
+105
| class TestStreamingCommand(StreamingCommand): | ||
| __test__ = False | ||
|
|
Contributor
There was a problem hiding this comment.
this one is not being referenced anywhere, wondering if we could remove it (could always bring it back from the version control if needed)
Contributor
Author
|
Closing in favor of #667. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves few warnings that were emitted by pytest.
See: https://docs.pytest.org/en/stable/example/pythoncollection.html#customizing-test-collection