CSPL-3580: Fix: Update Variable Formatting in deploy-eks-cluster.sh to Use ${variablename} for EBS Service Name Annotations

[vivekr-splunk]

Title: Fix: Update Variable Formatting in deploy-eks-cluster.sh to Use ${variablename} for EBS Service Name Annotations

Description:

This PR addresses the bug in the deploy-eks-cluster.sh script where the incorrect formatting of variables was causing failures when adding IAM roles to the service account. Specifically, the issue stemmed from using $variablename instead of ${variablename} for variable references, leading to incorrectly formatted values in the EBS service name annotations.

Changes Made:

• Updated the variable formatting in deploy-eks-cluster.sh from $variablename to ${variablename} to ensure proper handling in different shells.

Impact:

• This fix ensures that the correct variable references are used, preventing incorrect formatting and ensuring that IAM roles, EBS volumes, and role policies are correctly applied.
• The issue of the wrong name being added to the EBS service name annotations is resolved.

How to Test:

1. Run the make cluster-up command.
2. Verify that the cluster is created successfully without failures related to the incorrect formatting of variables.
3. Ensure that the correct names are added to the EBS service name annotations.

Related Jira Ticket: CSPL-3580 - Incorrect Formatting of IAM Role for Service Account

Expected Outcome:

• The script should run successfully and add the IAM role and EBS volume correctly, with accurate service name annotations.

[coveralls]

Pull Request Test Coverage Report for Build 14001571002

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.008%) to 86.59%

---

Totals
Change from base Build 13946362371:	0.008%
Covered Lines:	10538
Relevant Lines:	12170

---

💛 - Coveralls