Skip to content

Draft: Fix distroless workflow. #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Draft: Fix distroless workflow. #1448

wants to merge 2 commits into from

Conversation

Igor-splunk
Copy link
Collaborator

No description provided.

@Igor-splunk Igor-splunk changed the base branch from main to develop February 17, 2025 16:46
@coveralls
Copy link
Collaborator

coveralls commented Feb 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13375687218

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 86.573%
Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/afwscheduler.go 1 92.93%
Totals Coverage Status
Change from base Build 13313195382: 0.0%
Covered Lines: 10542
Relevant Lines: 12177
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13375064070

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 86.581%
Totals Coverage Status
Change from base Build 13313195382: 0.008%
Covered Lines: 10543
Relevant Lines: 12177
💛 - Coveralls

rlieberman-splunk
rlieberman-splunk reviewed Feb 17, 2025
View reviewed changes
.github/workflows/distroless-int-test-workflow.yml
@@ -46,8 +46,7 @@ jobs:
export PLATFORMS=linux/arm64,linux/amd64
export BASE_IMAGE=gcr.io/distroless/static-debian12
export BASE_IMAGE_VERSION=latest
export IMG=${{ secrets.ECR_REPOSITORY }}/${{ env.SPLUNK_OPERATOR_IMAGE_NAME }}:$GITHUB_SHA-distroless
make docker-buildx PLATFORMS=$PLATFORMS BASE_IMAGE=$BASE_IMAGE BASE_IMAGE_VERSION=$BASE_IMAGE_VERSION IMG=$IMG
make docker-buildx PLATFORMS=$PLATFORMS BASE_IMAGE=$BASE_IMAGE BASE_IMAGE_VERSION=$BASE_IMAGE_VERSION IMG=${{ secrets.ECR_REPOSITORY }}/${{ env.SPLUNK_OPERATOR_IMAGE_NAME }}:$GITHUB_SHA-distroless
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will still give the double -distroless tag. Either -distroless needs to be removed from here, or from the Makefile docker buildx command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlieberman-splunk rlieberman-splunk rlieberman-splunk left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Igor-splunk @coveralls @rlieberman-splunk