Fix: manage v3 secret from docker entrypoint #1271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwadhwani-splunk
force-pushed
the
fix/manage_v3_secret_from_docker_entrypoint
branch
from
83b7a51 to
c4c8a89
Compare
| From SC4SNMP 1.15.0, this process has been simplified and can manage all SNMPv3 secrets using a single secrets.json file. | ||
|
|
||
| #### 1. For setups not yet migrated to latest version | ||
| First, delete all existing secrets from docker-compose.yaml using manage_secrets.py with the following flags: |
There was a problem hiding this comment.
will it fail if the user won't do it? I'm afraid nobody's reading the documentation 😂
| | `--path_to_compose` | Absolute path to directory with docker compose files | | ||
| | `--delete` | Set this flag to true to delete the secret | | ||
|
|
||
| This will delete the secret with a given name from all docker compose files. If this secret hasn't been deleted from `.env` |
There was a problem hiding this comment.
Is there an option to delete all?
| --contextEngineId 090807060504037 | ||
| ``` | ||
| To create a new secret, | ||
| create secrets.json file inside folder (at SECRET_FOLDER_PATH), add entry for the new secrets with all the details. |
There was a problem hiding this comment.
let's add `` to secrets.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handled the creation and deletion of secrets from docker entrypoint using json file, instead of executing manage_secrets.py for each secrets before installation.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally
Checklist