fix: changes repeat_search_until method to return last search state as it should according to inline docs #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okashaev-splunk
force-pushed
the
fix_repeat_search_until
branch
from
1493083 to
987e6bc
Compare
…s it should according to inline docs
okashaev-splunk
force-pushed
the
fix_repeat_search_until
branch
from
987e6bc to
d0d3dd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
PR Type
What kind of change does this PR introduce?
Summary
Changes SplunkClientBase.repeat_search_until method to return last search state as declared by inline function documentation. Previously it was returning a boolean value provided by search_probe method that it invokes underline.
Changes
Please provide a summary of the changes.
User experience
Please describe the user experience before and after this change. Screenshots are welcome for additional context.
Checklist
If an item doesn't apply to your changes, leave it unchecked.