-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update npm #1651
Open
vtsvetkov-splunk
wants to merge
8
commits into
develop
Choose a base branch
from
feature/package-updates
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(deps): update npm #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafdc57
to
c5642ba
Compare
28330a0
to
5dd6949
Compare
5dd6949
to
c18d7b3
Compare
soleksy-splunk
requested changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately updates break dashboard page, rest works good, raised a question on slack if we should do anything with it or raise a bug and do not update for now
created a partial update in this PR. |
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: -
PR Type
What kind of change does this PR introduce?
Summary
Changes
uPlot
in@splunk/dashboard-utils
. There is a function call where the valuewindow.navigator.language
is passed toIntl.NumberFormat
constructor. The problem is the headless chromium in Ci sets the value toen-US@posix
and it cases the constructor to throw an error. The expected value isen-US
. This is fixed by specifyingLC_ALL=en_US
env variable before starting the storybook.window.matchMedia
polyfill is stolen from thedashboard-framework
repository since they also introduced it for running jest testsUser experience
No anticipated changes
Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear