Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update npm #1651

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

vtsvetkov-splunk
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk commented Mar 19, 2025

Issue number: -

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

  • Update all possible deps
  • There was an issue with the newly added package uPlot in @splunk/dashboard-utils. There is a function call where the value window.navigator.language is passed to Intl.NumberFormat constructor. The problem is the headless chromium in Ci sets the value to en-US@posix and it cases the constructor to throw an error. The expected value is en-US. This is fixed by specifying LC_ALL=en_US env variable before starting the storybook.
  • window.matchMedia polyfill is stolen from the dashboard-framework repository since they also introduced it for running jest tests

User experience

No anticipated changes

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@vtsvetkov-splunk vtsvetkov-splunk force-pushed the feature/package-updates branch from 5dd6949 to c18d7b3 Compare March 20, 2025 18:15
@vtsvetkov-splunk vtsvetkov-splunk marked this pull request as ready for review March 24, 2025 12:34
@vtsvetkov-splunk vtsvetkov-splunk requested review from a team as code owners March 24, 2025 12:34
Copy link
Contributor

@soleksy-splunk soleksy-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately updates break dashboard page, rest works good, raised a question on slack if we should do anything with it or raise a bug and do not update for now
Screenshot 2025-03-28 at 14 00 36

@soleksy-splunk
Copy link
Contributor

created a partial update in this PR.
Plus used resolution as way to force specific versions for axios and esbuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants