[Breaking change] Remove full import from ESM and CJS builds.
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…localhost_mode_and_full_entrypoint
EmilianoSanchez
changed the base branch from
breaking_changes
to
remove_pluggable_localhost_mode
EmilianoSanchez
changed the title
LocalhostFromObject export and full sub-package. full import from ESM and CJS builds.
Base automatically changed from
remove_pluggable_localhost_mode
to
breaking_changes
October 31, 2024 01:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native SDK
What did you accomplish?
import { SplitFactory } from '@splitsoftware/splitio-react-native/full'), since with the removal ofLocalhostFromObjectfrom the default import there is no difference between them.How do we test the changes introduced in this PR?
Extra Notes