[FME-4230] Events - Updated Segments #689
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCardozo-SDK
changed the title
|
SonarQube Quality Gate
|
MartinCardozo-SDK
changed the base branch from
FME-4222-events-withMetadata
to
FME-4228-events-updatedFlag
MartinCardozo-SDK
changed the title
MartinCardozo-SDK
changed the title
MartinCardozo-SDK
changed the base branch from
FME-4228-events-updatedFlag
to
withMetadata2
MartinCardozo-SDK
changed the base branch from
withMetadata2
to
FME-4229-events-killedFlag
gthea
reviewed
Jun 24, 2025
| splitEventsManager.notifyInternalEvent(.splitsUpdated) | ||
| func notifyUpdated(flagsList: [String]) { | ||
| let eventMetadata = EventMetadata(type: .FLAGS_UPDATED, data: flagsList.description) | ||
| splitEventsManager.notifyInternalEvent(.splitsUpdated, metadata: eventMetadata) |
There was a problem hiding this comment.
Let's add a test to verify the built eventMetadata that gets to the splitEventsManager.
Comment on lines
+210
to
+219
| func notifyFeatureFlagsUpdated(flagsList: [String]) { | ||
| featureFlagsSynchronizer.notifyUpdated(flagsList: flagsList) | ||
| } | ||
|
|
||
| func notifySegmentsUpdated(forKey key: String) { | ||
| byKeySynchronizer.notifyMySegmentsUpdated(forKey: key) | ||
| func notifySegmentsUpdated(forKey key: String, _ metadata: EventMetadata? = nil) { | ||
| byKeySynchronizer.notifyMySegmentsUpdated(forKey: key, metadata) | ||
| } | ||
|
|
||
| func notifyLargeSegmentsUpdated(forKey key: String) { | ||
| byKeySynchronizer.notifyMyLargeSegmentsUpdated(forKey: key) | ||
| func notifyLargeSegmentsUpdated(forKey key: String, _ metadata: EventMetadata? = nil) { | ||
| byKeySynchronizer.notifyMyLargeSegmentsUpdated(forKey: key, metadata) |
There was a problem hiding this comment.
We should add some tests to verify data gets to the specific synchronizers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS SDK
What did you accomplish?
Segments updated notification.
How do we test the changes introduced in this PR?
Extra Notes