Capture unrecognized fields with lint

Cargo.toml

@@ -70,6 +70,7 @@ is_default_derive_macro = { path = "crates/is_default_derive_macro" }
 libc = "0.2.80"
 miette = "7.0"
 nix = { version = "0.27.1", features = ["mount", "sched", "user"] }
+ngrammatic = "0.4.0"
 nom = "7.1"
 nom-supreme = "0.8"
 once_cell = "1.8"
@@ -137,6 +138,7 @@ spk-solve-validation = { path = "crates/spk-solve/crates/validation" }
 spk-storage = { path = "crates/spk-storage" }
 static_assertions = "1.1"
 strip-ansi-escapes = "0.2.0"
+struct-field-names-as-array = "0.3.0"
 strum = { version = "0.26.3", features = ["derive"] }
 tap = "1.0"
 tempfile = "3.3"

crates/spk-cli/group4/src/cmd_lint.rs

@@ -8,7 +8,8 @@ use clap::Args;
 use colored::Colorize;
 use miette::Result;
 use spk_cli_common::{flags, CommandArgs, Run};
-use spk_schema::{SpecTemplate, Template, TemplateExt};
+use spk_schema::Lint::Key;
+use spk_schema::{FromYaml, LintedSpec, SpecTemplate, Template, TemplateExt};
 
 /// Validate spk yaml files
 #[derive(Args)]
@@ -25,21 +26,39 @@ impl Run for Lint {
     type Output = i32;
 
     async fn run(&mut self) -> Result<Self::Output> {
-        let options = self.options.get_options()?;
         let mut out = 0;
+        let options = self.options.get_options()?;
         for spec in self.packages.iter() {
-            let result = SpecTemplate::from_file(spec).and_then(|t| t.render(&options));
-            match result {
-                Ok(_) => println!("{} {}", "OK".green(), spec.display()),
-                Err(err) => {
-                    println!(
-                        "{} {}:\n{} {err}",
-                        "Failed".red(),
-                        spec.display(),
-                        "----->".red()
-                    );
-                    out = 1;
+            let yaml = SpecTemplate::from_file(spec).and_then(|t| t.render_to_string(&options))?;
+            let s = LintedSpec::from_yaml(&yaml);
+            if s.is_ok() {
+                let valid_spec = s.unwrap();
+                match valid_spec {
+                    LintedSpec::V0Package(v) => {
+                        if v.lints.is_empty() {
+                            println!("{} {}", "OK".green(), spec.display())
+                        } else {
+                            println!("{} {}:", "Failed".red(), spec.display());
+                            for lint in v.lints {
+                                match lint {
+                                    Key(k) => {
+                                        println!("{} {}", "----->".red(), k.generate_message())
+                                    }
+                                }
+                            }
+                            out = 1;
+                        }
+                    }
                 }
+            } else {
+                let err = s.err().unwrap();
+                println!(
+                    "{} {}:\n{} {err}",
+                    "Failed".red(),
+                    spec.display(),
+                    "----->".red()
+                );
+                out = 1;
             }
         }
         Ok(out)

crates/spk-schema/Cargo.toml

@@ -28,6 +28,7 @@ ignore = "0.4.18"
 indexmap = { workspace = true }
 is_default_derive_macro = { workspace = true }
 itertools = { workspace = true }
+ngrammatic = { workspace = true }
 nom = { workspace = true }
 nom-supreme = { workspace = true }
 regex = { workspace = true }
@@ -43,6 +44,7 @@ spk-schema-foundation = { workspace = true }
 spk-schema-ident = { workspace = true }
 spk-schema-tera = { workspace = true }
 strum = { workspace = true }
+struct-field-names-as-array = { workspace = true }
 sys-info = "0.9.0"
 tempfile = { workspace = true }
 thiserror = { workspace = true }