Aligning spk-convert-pip with current SPI changes #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges. Versions up the spk-convert-pip spk package to v1.4.4 Signed-off-by: David Gilligan-Cook <[email protected]>
Signed-off-by: David Gilligan-Cook <[email protected]>
rydrman
reviewed
Jan 22, 2025
| spec = { | ||
| "pkg": f"{_to_spk_name(info.name)}/{_to_spk_version(info.version)}", | ||
| "api": "v0/package", | ||
| "sources": [], | ||
| "meta": { | ||
| "license": package_license, |
There was a problem hiding this comment.
still put this in the metadata, but you should be able to disable the license check - maybe this needs to be split out first to make this possible.
Aka split SpdxLicense rule into two (has license vs is spdx) and then make the semantics such that both can be disabled in these cases so that the actual included license is never checked.
build:
validation:
- rules:
- allow: SpdxLicense
- allow: HasLicense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the license field processing in
spk-convert-pipto align it with the current SPI license processing. The changes are from last September and move a code block around, as well as removing the "Unknown" default value.This also versions up the
spk-convert-pipspk package tov1.4.4to sync up the version numbers