Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Autobump korkVersion #1108

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

spinnakerbot
Copy link
Contributor

No description provided.

@spinnakerbot spinnakerbot force-pushed the autobump-korkVersion-master branch from c2bb492 to 2061b08 Compare September 23, 2024 16:43
@mergify mergify bot requested a review from a team September 23, 2024 16:45
…oovy 4.x

Replacing the groovy coordinates from `org.codehaus.groovy` to `org.apache.groovy` supported by groovy 4.x and above versions.
While upgrading groovy 4.0.15, encounter below error during build process of rosco-core module:
```
startup failed:
/rosco/rosco-core/src/main/groovy/com/netflix/spinnaker/rosco/api/BakeRequest.groovy: -1: Access to java.lang.Object#request_id is forbidden @ line -1, column -1.
1 error

> Task :rosco-core:compileGroovy FAILED
```
In order to make `request_id` accessible, removed `final` access specifier and updated the deprecated `ApiModelProperty.readOnly()` method with `ApiModelProperty.AccessMode()` [method](https://docs.swagger.io/swagger-core/v1.5.X/apidocs/io/swagger/annotations/ApiModelProperty.html#readOnly()).
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Sep 23, 2024
@mergify mergify bot added the auto merged label Sep 23, 2024
@mergify mergify bot merged commit eb42b5f into spinnaker:master Sep 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants