Skip to content

this target is already set in .cargo/config.toml #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tshepang
Copy link

I suspect the docs would have to be updated if this change is accepted.

@radu-matei
Copy link
Member

radu-matei commented Aug 16, 2022

This is something we have talked about in #672 as well — and there, we explored removing .cargo/config.toml instead.

What do you think?

Thank you for your contribution!

@tshepang
Copy link
Author

tshepang commented Aug 16, 2022

After reading that #672, I agree that removing .cargo/config.toml is a better change:

  • Causes less issues with cargo test
  • It's a hidden config, and has just one setting
  • That setting is done in all templates

@tshepang tshepang closed this Aug 16, 2022
@tshepang tshepang deleted the redundant branch August 16, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants