Use connection pooling when querying CosmosDB #3017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that KV reads/writes had a really high latency with the CosmosDB provider. I crated some simple test cases for interacting with CosmosDB and found that while the go SDK reuses connections between requests, the Rust SDK always created a new client. @lann discovered that the Azure Rust SDK disabled connection pooling because of this upstream issue: hyperium/hyper#2312. The maintainers closed the issue deeming it to be irreproducible. I am getting latencies 3x higher without connection pooling (from 15ms reads to 60ms reads). I think it is worth enabling the pooling by creating our own reqwest client and passing it.
I put it behind a feature flag in case we do hit the deadlock scenario that some have experienced.
Marking this as draft for discussionSeems like this is a change we want