Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA: support staticNis and dynamicNics #4695

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

Sorry, something went wrong.

@cyclinder cyclinder added the release/feature-new release note for new feature label Feb 28, 2025
@cyclinder cyclinder force-pushed the dra/v1beta1 branch 4 times, most recently from 0ddd782 to e1b8583 Compare March 20, 2025 03:49
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 94 lines in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (7a9370d) to head (ba64f5f).

Files with missing lines Patch % Lines
pkg/podmanager/utils.go 0.00% 77 Missing ⚠️
pkg/podmanager/pod_webhook.go 0.00% 12 Missing ⚠️
pkg/utils/utils.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4695      +/-   ##
==========================================
- Coverage   75.39%   74.31%   -1.08%     
==========================================
  Files          56       56              
  Lines        6820     6911      +91     
==========================================
- Hits         5142     5136       -6     
- Misses       1466     1562      +96     
- Partials      212      213       +1     
Flag Coverage Δ
unittests 74.31% <0.00%> (-1.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/utils/utils.go 65.76% <0.00%> (-3.11%) ⬇️
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)
pkg/podmanager/utils.go 30.97% <0.00%> (-21.32%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Cyclinder Kuo <[email protected]>
Debug dra
Signed-off-by: Cyclinder Kuo <[email protected]>
fix
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
@@ -233,6 +237,15 @@ spec:
- name: host-ns
mountPath: /var/run/netns
mountPropagation: Bidirectional
{{- end }}
{{- if .Values.spiderpoolAgent.dra.enabled }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个建议不要做这个判断,而是默认就是要加载,因为 开关由 configmap 中决定,否则功能的 使能 就不是简单 设置 configmap,而是要 helm upgrade 。那么 configmap 中的 开关作用 就不大了

这里 理想的是 应该是要 通过 helm 检测 k8s ablitiy dra ,来决定是否加载

Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
@cyclinder cyclinder changed the title DRA: support staticNis for multi-network DRA: support staticNis and dynamicNics Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/feature-new release note for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants