-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRA: support staticNis and dynamicNics #4695
base: main
Are you sure you want to change the base?
Conversation
0ddd782
to
e1b8583
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4695 +/- ##
==========================================
- Coverage 75.39% 74.31% -1.08%
==========================================
Files 56 56
Lines 6820 6911 +91
==========================================
- Hits 5142 5136 -6
- Misses 1466 1562 +96
- Partials 212 213 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
Signed-off-by: Cyclinder Kuo <[email protected]>
@@ -233,6 +237,15 @@ spec: | |||
- name: host-ns | |||
mountPath: /var/run/netns | |||
mountPropagation: Bidirectional | |||
{{- end }} | |||
{{- if .Values.spiderpoolAgent.dra.enabled }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个建议不要做这个判断,而是默认就是要加载,因为 开关由 configmap 中决定,否则功能的 使能 就不是简单 设置 configmap,而是要 helm upgrade 。那么 configmap 中的 开关作用 就不大了
这里 理想的是 应该是要 通过 helm 检测 k8s ablitiy dra ,来决定是否加载
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #
Special notes for your reviewer: