Release 0.1.0 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwtExpired() needed to be updated since atob throws an exception if it can't access the 2nd element in the array generated by split(). Since this means that there is no valid token, return true when it happens
|
I might have to do some changes in game.js @Marleematic |
For whatever reason (I couldn't figure out in the last 2 entire days) when using application/json the JSON.parse() function in the server crashes (you also can't just take the requst body since it is still a string). It works with plain text though so even though it's technically incorrect to use text/plain we'll use it until somebody figures out what the hell is wrong. Do note that the same request (Content-Type also application/json) but made from a REST client works perfectly fine. Also opening an issue for this
|
Update: Change has been implemented, you can go ahead and review now @Marleematic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First functional interface
Register, login and logout work