Support latest Debian libsecp256k1 package #8185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's available as: |
|
Thanks. I also don't understand why our own |
SomberNight
added a commit
that referenced
this pull request
Feb 3, 2023
|
I've added a follow-up in dd141c7 based on bitcoin-core/secp256k1#1055 (comment) but I still don't understand why electrum/contrib/make_libsecp256k1.sh Line 65 in 240edb4 |
SomberNight
added a commit
that referenced
this pull request
Feb 3, 2023
unneeded since bitcoin-core/secp256k1@c0cd7de and in fact buggy since bitcoin-core/secp256k1@0bd3e42 related #8185 (comment)
|
ok, figured it out. |
|
Many thanks! |
|
Oh, this may be a bad idea. See recent discussion here: rust-bitcoin/rust-secp256k1#566 (comment) |
|
I don't fully understand what you mean.
What part specifically is the bad idea? |
|
Basically, I'm not really sure it's safe. Pinging @apoelstra if you have time could you give us a hint whether depending on Ubuntu -packaged |
|
If it's the recently-released 0.2 then it should be fine. We deliberately chose 0.2 because as far as we're aware, the "shouldn't have been packaged" packages used 0.1, so it should be easy to tell :). |
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 21, 2023
We don't actually need the development headers, instead using this as a hack to be agnostic to the version scheme and pull in the latest. related: spesmilo#8185 spesmilo#8320 spesmilo#8328 (comment) debian 11 (stable) only has libsecp256k1-0 debian 12 (testing) atm only has libsecp256k1-1 ubuntu 23.04 only has libsecp256k1-1 I expect libsecp256k1-2 might soon get packaged too, now that upstream secp released v0.3.0. So what do tell users to install? well, turns out most distros have libsecp256k1-dev, which just pull in the latest secp. Caveat: if there is a new secp release that actually gets packaged on a distro before we can react, then this new instruction will not work.
SomberNight
added a commit
that referenced
this pull request
Apr 21, 2023
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 21, 2023
We don't actually need the development headers, instead using this as a hack to be agnostic to the version scheme and pull in the latest. related: spesmilo#8185 spesmilo#8320 spesmilo#8328 (comment) debian 11 (stable) only has libsecp256k1-0 debian 12 (testing) atm only has libsecp256k1-1 ubuntu 23.04 only has libsecp256k1-1 I expect libsecp256k1-2 might soon get packaged too, now that upstream secp released v0.3.0. So what do we tell users to install? well, turns out most distros have libsecp256k1-dev, which just pulls in the latest secp. Caveat: if there is a new secp release that actually gets packaged on a distro before we can react, then this new instruction will not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://packages.debian.org/source/testing/libsecp256k1