Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 137 add transition to mapping #168

Merged
merged 4 commits into from
Feb 22, 2022
Merged

Feature/issue 137 add transition to mapping #168

merged 4 commits into from
Feb 22, 2022
+390 −9

Conversation

osoken
Copy link
Collaborator

@osoken osoken commented Feb 20, 2022

No description provided.

@osoken
test(frontend): add some tests for mapped-budget-candidates

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
81cefe9
@osoken
feature(frontend/backend): add create or edit MappingBudget from Basi…
bde28f7 
…cBudget viewer
@osoken
Copy link
Collaborator Author

osoken commented Feb 21, 2022

closes #137

@osoken osoken linked an issue Feb 21, 2022 that may be closed by this pull request
予算閲覧画面にマッピング画面への遷移を追加 #137
Closed
@osoken
Copy link
Collaborator Author

osoken commented Feb 21, 2022

編集ボタンの出現位置全然変なまま PR 出してました 笑
昨日やっぱり疲れてたんだなぁ・・・
Screenshot from 2022-02-21 22-01-04

Screenshot from 2022-02-21 22-07-57

@yuukiootaki
Copy link
Contributor

コードの変更点は OK だと思いました。

Pull Request の脇道にはそれますが、UI 触っていて思ったこと

  • Budget 作成時にサーバー側でエラーが起きた場合に UI になにか表示したほうが親切（ layouts/default.vue にエラーが出たら v-alert を出す機能を追加する #170 ?）
  • 新しいマッピングを作成する方法が初見にわかりにくいかも
    　　* sourceBudget がない Budget を探してから編集ボタンを押さないといけない。トップページで sourceBudget がある budget とない budget をフラットに表示しているからかも。

@yuukiootaki yuukiootaki merged commit c7bb4c0 into develop Feb 22, 2022
@takano32 takano32 deleted the feature/issue-137-add-transition-to-mapping branch February 23, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

予算閲覧画面にマッピング画面への遷移を追加
2 participants
@osoken @yuukiootaki