Remove MANIFEST.in; Migrate to pyproject.toml#883
Open
Conversation
With the use of setuptools_scm, all files that are tracked with the version control system will be included in the distribution anyway -- so there's no need to declared "graft/include" in the MANIFEST.in. The side effect of completely remove MANIFEST.in is the egg-info will be included. As setuptools can't be configured to prune src/spdx_tools.egg-info via pyproject.toml config. But the inclusion of egg-info is actually a standard practice (setuptools itself also include this information). The additional size of sdist when include the egg-info is 5.6 kbytes (704,357 vs 698,744 bytes). If needed, we can also include a minimal MANIFEST.in with one line: prune src/spdx_tools.egg-info to exclude the egg-info from sdist Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove MANIFEST.in and migrate to pyproject.toml
Modernize .gitignore