Skip to content

[issue-839] Drop Python 3.7 support and fix CI pipeline issues #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

armintaenzertng
Copy link
Collaborator

@armintaenzertng armintaenzertng commented Jan 24, 2025

fixes #839
after some updates, this also fixes #844

ubuntu-latest does not support Python 3.7 anymore.
See actions/runner-images#10636

@armintaenzertng armintaenzertng force-pushed the issue-839-fix-github-actions-workflow branch from 1afd311 to 55ce856 Compare January 24, 2025 09:07
@kestewart
Copy link
Contributor

Concerned that we should not be pegging to a version of Ubuntu which will become stale. What are the implications of updating to a newer version of python?

@kestewart kestewart requested a review from licquia January 24, 2025 15:42
@armintaenzertng
Copy link
Collaborator Author

@kestewart, it's not about upgrading our Python version (we already support at least 3.11) but about whether we want to drop Python 3.7 support.
Python 3.7 reached end-of-life on 2023-06-27, but still seems to be in use by some people.

Note that we wouldn't immediately lose compatibility when erasing it from the pipeline, but we wouldn't catch changes in our code that break for Python 3.7, so we couldn't guarantee 3.7 support anymore.

@maxhbr
Copy link
Member

maxhbr commented Jan 31, 2025

I think we should drop support for python versions that are EOL

@kestewart
Copy link
Contributor

@armintaenzertng, @maxhbr - no issue with dropping support - what I was objecting to was the pegging to an old version of ubuntu, rather than staying with the latest. If I've misunderstood what the patch is doing, please explain.

@maxhbr
Copy link
Member

maxhbr commented Jan 31, 2025

good point, lets drop old versions and stay with latest ubuntu

@armintaenzertng armintaenzertng force-pushed the issue-839-fix-github-actions-workflow branch from 55ce856 to 33ef9c6 Compare April 11, 2025 12:17
@armintaenzertng armintaenzertng force-pushed the issue-839-fix-github-actions-workflow branch from 33ef9c6 to d90b8af Compare April 11, 2025 12:26
@armintaenzertng
Copy link
Collaborator Author

Sorry for the slow response. In order to get the pipeline running again I had to do several fixes:

  • No Python 3.7 support anymore, as discussed
  • Updated the exception raised by the type checking due to a new version of beartype
  • Updated formatting due to a new version of black

@maxhbr, could you please remove the Python 3.7 checks from this repo? :)

Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nit: you could update the PRs description

@meretp
Copy link
Collaborator

meretp commented Apr 11, 2025

btw 3.8 is also eol, isn't? we could drop that as well and should check if we support 3.12 and 3.13

Comment on lines 5 to 8

from beartype import beartype
from beartype.roar import BeartypeCallHintException
from beartype.roar import BeartypeCallHintParamViolation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this relate to #844, does this change fix the issue mentioned there?

@armintaenzertng armintaenzertng changed the title [issue-839] Run GH Actions workflow on ubuntu-22.04 instead of ubuntu-latest [issue-839] Drop Python 3.7 support and fix CI pipeline issues Apr 17, 2025
@armintaenzertng armintaenzertng merged commit 8dc336f into spdx:main Apr 17, 2025
26 checks passed
@armintaenzertng armintaenzertng deleted the issue-839-fix-github-actions-workflow branch April 17, 2025 13:32
@armintaenzertng
Copy link
Collaborator Author

I don't see an urgent need to drop support for 3.8 as long as it doesn't cost us anything. But I agree that we should check if we can add support for 3.12 and 3.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when using beartype 0.20.0 Some checks, that are not allways running, are marked as mandatory
4 participants