-
Notifications
You must be signed in to change notification settings - Fork 138
[issue-839] Drop Python 3.7 support and fix CI pipeline issues #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue-839] Drop Python 3.7 support and fix CI pipeline issues #841
Conversation
1afd311
to
55ce856
Compare
Concerned that we should not be pegging to a version of Ubuntu which will become stale. What are the implications of updating to a newer version of python? |
@kestewart, it's not about upgrading our Python version (we already support at least 3.11) but about whether we want to drop Python 3.7 support. Note that we wouldn't immediately lose compatibility when erasing it from the pipeline, but we wouldn't catch changes in our code that break for Python 3.7, so we couldn't guarantee 3.7 support anymore. |
I think we should drop support for python versions that are EOL |
@armintaenzertng, @maxhbr - no issue with dropping support - what I was objecting to was the pegging to an old version of ubuntu, rather than staying with the latest. If I've misunderstood what the patch is doing, please explain. |
good point, lets drop old versions and stay with latest ubuntu |
55ce856
to
33ef9c6
Compare
Signed-off-by: Armin Tänzer <[email protected]>
33ef9c6
to
d90b8af
Compare
Otherwise, pytest will complain. Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Sorry for the slow response. In order to get the pipeline running again I had to do several fixes:
@maxhbr, could you please remove the Python 3.7 checks from this repo? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nit: you could update the PRs description
btw 3.8 is also eol, isn't? we could drop that as well and should check if we support 3.12 and 3.13 |
|
||
from beartype import beartype | ||
from beartype.roar import BeartypeCallHintException | ||
from beartype.roar import BeartypeCallHintParamViolation | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this relate to #844, does this change fix the issue mentioned there?
I don't see an urgent need to drop support for 3.8 as long as it doesn't cost us anything. But I agree that we should check if we can add support for 3.12 and 3.13. |
fixes #839
after some updates, this also fixes #844
ubuntu-latest does not support Python 3.7 anymore.
See actions/runner-images#10636