Skip to content

Conversation

LuisMartinPoloESA
Copy link
Contributor

No description provided.

LuisMartinPoloESA added a commit to LuisMartinPoloESA/license-list-XML that referenced this pull request Aug 20, 2025
LuisMartinPoloESA added a commit to LuisMartinPoloESA/license-list-XML that referenced this pull request Aug 20, 2025
Add ESA-PL-strong-copyleft-2.4

Add ESA-PL-strong-copyleft-2.4
@LuisMartinPoloESA LuisMartinPoloESA force-pushed the ESA-PL-strong-copyleft-2.4 branch 2 times, most recently from 3a294f4 to a7fe2e0 Compare August 20, 2025 11:57
Copy link

@lase3511 lase3511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gffyuiiu

<?xml version="1.0" encoding="UTF-8"?>
<SPDXLicenseCollection xmlns="http://www.spdx.org/license">
<license isOsiApproved="false" licenseId="ESA-PL-strong-copyleft-2.4"
name="European Space Agency Public License (ESA-PL) - V2.4 - Strong Copyleft (Type 1)" listVersionAdded="3.28.0">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approved name i.e. what is in the issue is "European Space Agency Public License (ESA-PL) Strong Copyleft (Type 1)". Although the other two ESA licenses has the version in the name. So this version what is in this PR makes more sense to me.
@jlovejoy can you confirm?

@xsuchy xsuchy dismissed lase3511’s stale review August 23, 2025 21:27

Does not make sense. Spam?

@LuisMartinPoloESA LuisMartinPoloESA force-pushed the ESA-PL-strong-copyleft-2.4 branch from a7fe2e0 to e726f08 Compare September 5, 2025 12:03
@xsuchy
Copy link
Collaborator

xsuchy commented Sep 7, 2025

This is wrong conentent. You pushed permisive license instead of the strong-copyleft. I think you confused branch names.

Date updated

Delete src/ESA-PL-permissive-2.4.xml

Fixes: spdx#2722

Added Slovenia and missing bullets

Fixes: spdx#2722

Add ESA-PL-strong-copyleft-2.4

Add ESA-PL-strong-copyleft-2.4
@LuisMartinPoloESA LuisMartinPoloESA force-pushed the ESA-PL-strong-copyleft-2.4 branch from 82128b1 to 6582f53 Compare September 12, 2025 11:16
@LuisMartinPoloESA
Copy link
Contributor Author

Indeed! Should be fixed now.

@LuisMartinPoloESA
Copy link
Contributor Author

BTW, is there any chance we can still make a change to the permissive and weak licenses? We discovered a typo we'd like to fix, but pull requests have been already merged.

@xsuchy
Copy link
Collaborator

xsuchy commented Sep 13, 2025

BTW, is there any chance we can still make a change to the permissive and weak licenses? We discovered a typo we'd like to fix, but pull requests have been already merged.

You have to open new PR. If the typo is technically then you can open PR directly. If you expect some discussion about it, then please open issue first.

@LuisMartinPoloESA
Copy link
Contributor Author

Are there any open issues pending for this PR?

Copy link
Collaborator

@xsuchy xsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@xsuchy xsuchy merged commit 4765bf7 into spdx:main Oct 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants