-
Notifications
You must be signed in to change notification settings - Fork 342
Add ESA-PL-strong-copyleft-2.4 #2820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESA-PL-strong-copyleft-2.4 #2820
Conversation
3a294f4
to
a7fe2e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gffyuiiu
<?xml version="1.0" encoding="UTF-8"?> | ||
<SPDXLicenseCollection xmlns="http://www.spdx.org/license"> | ||
<license isOsiApproved="false" licenseId="ESA-PL-strong-copyleft-2.4" | ||
name="European Space Agency Public License (ESA-PL) - V2.4 - Strong Copyleft (Type 1)" listVersionAdded="3.28.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approved name i.e. what is in the issue is "European Space Agency Public License (ESA-PL) Strong Copyleft (Type 1)". Although the other two ESA licenses has the version in the name. So this version what is in this PR makes more sense to me.
@jlovejoy can you confirm?
a7fe2e0
to
e726f08
Compare
This is wrong conentent. You pushed permisive license instead of the strong-copyleft. I think you confused branch names. |
82128b1
to
6582f53
Compare
Indeed! Should be fixed now. |
BTW, is there any chance we can still make a change to the permissive and weak licenses? We discovered a typo we'd like to fix, but pull requests have been already merged. |
You have to open new PR. If the typo is technically then you can open PR directly. If you expect some discussion about it, then please open issue first. |
Are there any open issues pending for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No description provided.