Skip to content

Conversation

coky-t
Copy link
Contributor

@coky-t coky-t commented Jul 28, 2025

The following license is considered to be BSD-Attribution-HPND-disclaimer, but there are some inconsistencies in the license text.

https://github.com/ppp-project/ppp/blob/v2.5.0/pppd/eui64.c#L6-L33
https://github.com/ppp-project/ppp/blob/v2.5.0/pppd/mppe.h#L6-L33

I've added some markup to improve it.

The following license is considered to be BSD-Attribution-HPND-disclaimer, but there are some inconsistencies in the license text.

https://github.com/ppp-project/ppp/blob/v2.5.0/pppd/eui64.c#L6-L33
https://github.com/ppp-project/ppp/blob/v2.5.0/pppd/mppe.h#L6-L33

I've added some markup to improve it.
@jlovejoy
Copy link
Member

is there a corresponding issue for this, @coky-t ?

@coky-t
Copy link
Contributor Author

coky-t commented Jul 29, 2025

There are no currently open issues related to this pull request.
I apologize if this violates the pull request rules.

The related issue is already closed, issue #2323.
This issue was addressed in pull request #2359, but the markup in that pull request seems insufficient.

There are two promblems:

  1. In paul-mackerras-binary, the subject of the disclaimer sentence is "THE AUTHORS", so the verb "DISCLAIM" is used instead of "DISCLAIMS".
  2. paul-mackerras-binary does not use the proper noun "CARNEGIE MELLON UNIVERSITY". Therefore, all occurrences of "CARNEGIE MELLON UNIVERSITY" in BSD-Attribution-HPND-disclaimer need to be addressed with markup, but there is still one occurrence remaining in the disclaimer text.

I have created this pull request to address these two problems.

There was an inconsistency in the markup, which has been fixed.
@coky-t
Copy link
Contributor Author

coky-t commented Aug 7, 2025

@jlovejoy,
Could you please confirm if I provided enough information in the above comment?
Or should I just abandon this pull request and create a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants