move content of test/simpleTestForGenerator to test/fullTestForGenerator #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, almost no one is using the directory
fullTestForGenerator/(license-id)/license/good/for tests and storing more variants of licenses. Including me, because I take some existing license as an example. This new directory has been supported by the publisher for some time.I suggest that we move all files from
test/simpleTestForGenerator/${@}.txttotest/fullTestForGenerator/${@}/license/good/${@}.txt.This is just a draft that moves MIT license and change
test-one-licensescript (it will now pass for MIT but fail for anything else).Let me know what do you think. If you would like it, I will draft a PR that moves all tests. But the final PR will be huge and hard to review. That is why I am making this draft first.