Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/1630] Add QR code button on signed transaction screen #1631

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

ThauanAmorim
Copy link
Contributor

Task: #1630

New version:
image
image

ChangeLog:

  • Added “Show Transaction as QR” button on signed transaction screen

@craigraw
Copy link
Collaborator

There are several issues here:

  • The type of QR code shown is always BBQr (as opposed to UR). What device/app is reading this?
  • Two default buttons onscreen
  • The order of buttons (from left to right) differs from the previous signing screen. There, showing the QR code is on the left. Here is it on the right, where probably it should be in the middle.

@ThauanAmorim
Copy link
Contributor Author

@craigraw
New version:
image

About "The type of QR code shown is always BBQr (as opposed to UR). What device/app is reading this?":

The QR code that appears is exactly the same as the one that appears in “file -> Show Transaction as QR”
image
So I don't think it's broken.

@craigraw
Copy link
Collaborator

Please motivate for this in the original issue.

@ThauanAmorim
Copy link
Contributor Author

@craigraw Done!

Copy link
Collaborator

@craigraw craigraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested. Please squash to one commit.

@craigraw craigraw merged commit b366177 into sparrowwallet:master Feb 13, 2025
@craigraw
Copy link
Collaborator

Thanks :)

@ThauanAmorim ThauanAmorim deleted the feature/1630 branch February 13, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants