Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests pass on bigendian architecture #616

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

flavorjones
Copy link
Member

Fixes #615 reporting failures on s390x.

Fixes #615 reporting failures on s390x.
@flavorjones
Copy link
Member Author

@voxik Please let me know if you're able to check that this PR passes on s390x hardware, I have no way of verifying it myself.

@flavorjones
Copy link
Member Author

Hmm, looks like I can run s390x on Github Actions runners using qemu emulation. Going to add a commit to this PR to add test coverage.

@flavorjones
Copy link
Member Author

Ugh, the emulation layer is painfully slow, maybe because of the endianness conversion that qemu has to do? The aarch64 emulation isn't this slow.

So I'm going to validate on my local machine that this works, and will omit adding it to CI.

@flavorjones
Copy link
Member Author

Looking good here:

root@4e0033608acf:/sqlite3-ruby-mount# bundle exec rake test A=-n/Pragmas/
---
:ruby: ruby 3.3.4 (2024-07-09 revision be1089c8ec) [s390x-linux-gnu]
:gem:
  :version: 2.5.0
:sqlite:
  :compiled: 3.47.2
  :loaded: 3.47.2
  :packaged: true
  :precompiled: false
  :sqlcipher: false
  :threadsafe: true
Run options: -n/Pragmas/ --seed 25872

# Running:

........

Finished in 0.066158s, 120.9221 runs/s, 332.5358 assertions/s.

8 runs, 22 assertions, 0 failures, 0 errors, 0 skips

Merging.

@flavorjones flavorjones merged commit a6e47d8 into main Jan 31, 2025
136 checks passed
@flavorjones flavorjones deleted the flavorjones-test-use-proper-native-endianness branch January 31, 2025 19:13
@voxik
Copy link
Contributor

voxik commented Feb 3, 2025

@voxik Please let me know if you're able to check that this PR passes on s390x hardware, I have no way of verifying it myself.

Yep, it solves the issue. Thanks a lot for the quick fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding errror on s390x
2 participants