Switch default HTML parser to Nokogiri::HTML5 #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the default HTML parser from `Nokogiri::HTML` (HTML4) to `Nokogiri::HTML5`. This provides better parsing accuracy for modern web pages but is stricter regarding encoding. Changes include: - Set `Mechanize.html_parser` default to `Nokogiri::HTML5`. - Update `Mechanize::Util.from_native_charset` and `html_unescape` to handle `Nokogiri::HTML5` by checking parser type and falling back to `Nokogiri::HTML::NamedCharacters` when needed (HTML5 parser lacks this constant). - Update `Mechanize::Page#parser` to rescue `Encoding::UndefinedConversionError` and `ArgumentError` during encoding detection, as Nokogiri::HTML5 raises errors for invalid encodings where HTML4 was lenient. - Fix `test/htdocs/frame_test.html` to be valid HTML5 (move content into NOFRAMES) to allow proper testing. - Update tests to expect UTF-8 encoding when using HTML5 parser (which enforces UTF-8). - Update legacy frameset tests to use compatible pages when running with HTML5 parser, as it handles NOFRAMES content differently. Closes sparklemotion#592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the default HTML parser from
Nokogiri::HTML(HTML4) toNokogiri::HTML5. This provides better parsing accuracy for modern web pages but is stricter regarding encoding.Changes include:
Mechanize.html_parserdefault toNokogiri::HTML5.Mechanize::Util.from_native_charsetandhtml_unescapeto handleNokogiri::HTML5by checking parser type and falling back toNokogiri::HTML::NamedCharacterswhen needed (HTML5 parser lacks this constant).Mechanize::Page#parserto rescueEncoding::UndefinedConversionErrorandArgumentErrorduring encoding detection, as Nokogiri::HTML5 raises errors for invalid encodings where HTML4 was lenient.test/htdocs/frame_test.htmlto be valid HTML5 (move content into NOFRAMES) to allow proper testing.Closes #592