Skip to content

Adjust checksum during unicore command response #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adjust checksum during unicore command response #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Parse_NMEA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ void sempNmeaValidateChecksum(SEMP_PARSE_STATE *parse)
checksum = sempAsciiToNibble(parse->buffer[parse->length - 2]) << 4;
checksum |= sempAsciiToNibble(parse->buffer[parse->length - 1]);

// If this is a command response from a Unicore module, include the '$' in the checksum
if(strcmp((char *)scratchPad->nmea.sentenceName, "command") == 0)
parse->crc ^= '$';

// Validate the checksum
if ((checksum == parse->crc) || (parse->badCrc && (!parse->badCrc(parse))))
{
Expand All @@ -63,6 +67,7 @@ void sempNmeaValidateChecksum(SEMP_PARSE_STATE *parse)
parse->eomCallback(parse, parse->type); // Pass parser array index
}
else
{
// Display the checksum error
sempPrintf(parse->printDebug,
"SEMP: %s NMEA %s, 0x%04x (%d) bytes, bad checksum, "
Expand All @@ -73,6 +78,10 @@ void sempNmeaValidateChecksum(SEMP_PARSE_STATE *parse)
parse->buffer[parse->length - 2],
parse->buffer[parse->length - 1],
parse->crc);

// Dump the buffer
sempPrintf(parse->printDebug, "SEMP Buffer: %s", parse->buffer);
}
}

// Read the linefeed
Expand Down