Skip to content

Conversation

@BartMemelink
Copy link
Contributor

  • update readme with environment variables descriptions
  • add client credential option for authentication instead of a fixed token

note: the token url is now provided from the environment variables. The solution could be expanded later on with discovery from well-known endpoints according to the rfc9728 spec

@sparfenyuk
Copy link
Owner

Looks great! Can you please revise the solution since it has some conflicts as of now. Also, consider command-line arguments in addition to env vars.

@BartMemelink
Copy link
Contributor Author

Hi @sparfenyuk I do agree the command-line arguments are a better fit. I have updated the solution and also resolved the conflicts. Most appreciated if you can have another look!

Copy link
Owner

@sparfenyuk sparfenyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fix the build checks.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/mcp_proxy/__main__.py 50.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (69.23%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   87.54%   87.29%   -0.25%     
==========================================
  Files          11       11              
  Lines        1092     1102      +10     
  Branches       64       64              
==========================================
+ Hits          956      962       +6     
- Misses        117      121       +4     
  Partials       19       19              
Files with missing lines Coverage Δ
src/mcp_proxy/sse_client.py 69.23% <100.00%> (+2.56%) ⬆️
src/mcp_proxy/streamablehttp_client.py 69.23% <100.00%> (+2.56%) ⬆️
tests/test_cli_arguments.py 94.11% <100.00%> (ø)
src/mcp_proxy/__main__.py 44.82% <50.00%> (+0.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eeaa4b...4ae229f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sparfenyuk sparfenyuk merged commit 1132740 into sparfenyuk:main Oct 27, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants