-
Notifications
You must be signed in to change notification settings - Fork 202
Add client credentials authentication for SSE and streamable http mcp server connections #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks great! Can you please revise the solution since it has some conflicts as of now. Also, consider command-line arguments in addition to env vars. |
|
Hi @sparfenyuk I do agree the command-line arguments are a better fit. I have updated the solution and also resolved the conflicts. Most appreciated if you can have another look! |
sparfenyuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Fix the build checks.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (69.23%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 87.54% 87.29% -0.25%
==========================================
Files 11 11
Lines 1092 1102 +10
Branches 64 64
==========================================
+ Hits 956 962 +6
- Misses 117 121 +4
Partials 19 19
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
note: the token url is now provided from the environment variables. The solution could be expanded later on with discovery from well-known endpoints according to the rfc9728 spec