mega datafield names cleanup #35093
Closed
mega datafield names cleanup #35093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzk228
requested review from
metalgearsloth,
Partmedia,
ficcialfaint,
TheShuEd,
DrSmugleaf,
nikthechampiongr and
crazybrain23
as code owners
github-actions
bot
added
S: Needs Review
|
well damn |
|
Was this done with the code fixer or some find and replace magic? |
|
magic of course |
|
Ah, okay, good. Wanted to make sure the code fixer isn't messed up. For the record, I dunno if a bulk change of these is a great idea, since it's merge conflict bait. If the count ever gets low enough though, I'd love to promote it to an actual warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup datafield names as they can be taken from the variable name
may be some breaking changes