Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry turrets - Part 2: Basic prototype #35031

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Sentry turrets - Part 2: Basic prototype #35031

wants to merge 8 commits into from

Conversation

chromiumboy
Copy link
Contributor

@chromiumboy chromiumboy commented Feb 10, 2025 •
edited
Loading

About the PR

This PR reorganizes the turret prototypes and creates parent prototypes from which both ballistic and energy weapon turrets can inherit. It also adds prototypes for a pair of new energy-based projectiles and their accompanying muzzle flashes.

A new field has also been added to BatterySelfRechargerComponent, allowing the specification of whether the attached entity needs to be connected to an APC power net to self-recharge (used by energy turrets).

This PR requires #35025

Why / Balance

This PR will be required for later PRs in this series

Technical details

N/A

Media

N/A

Requirements

Breaking changes

Ballistic turrets must now inherit from BaseWeaponBallisticTurret instead of BaseWeaponTurret

Changelog

N/A

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 10, 2025
@ArtisticRoomba ArtisticRoomba added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. labels Feb 10, 2025
@chromiumboy chromiumboy deleted the senty-turret-base-prototype branch February 11, 2025 02:34
@chromiumboy chromiumboy restored the senty-turret-base-prototype branch February 11, 2025 04:50
@chromiumboy
Copy link
Contributor Author

Oops, I tried to rename the branch and it closed it :P

@chromiumboy chromiumboy reopened this Feb 11, 2025
@chromiumboy chromiumboy added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Content PR Merged Status: Requires an existing SS14 PR to be merged first. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chromiumboy @ArtisticRoomba