Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix references to obsolete TryGetContainingContainer override #34912

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix references to obsolete TryGetContainingContainer override #34912

merged 1 commit into from
Feb 11, 2025

Conversation

TemporalOroboros
Copy link
Contributor

About the PR

Changed two calls to TryGetContainingContainer to be compatible with the Entity<T> override.

Why / Balance

It decreases the number of compile warnings that we get spammed with when we compile.

Technical details

Changed one call to explicitly use the .Owner for the previously used entity as it can be implicitly converted to the required Entity<T> and the entity it was already passing could not.
Changed the other call to pass the correct Entity<T> instead of passing the uid and components separately.

Media

Requirements

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Feb 6, 2025
@TemporalOroboros TemporalOroboros mentioned this pull request Feb 6, 2025
Open
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
slarticodefast
slarticodefast approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@slarticodefast slarticodefast merged commit 66ff1aa into space-wizards:master Feb 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TemporalOroboros @slarticodefast @ArtisticRoomba