Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deathsquad revolver ammo fix #34910

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Deathsquad revolver ammo fix #34910

merged 3 commits into from
Feb 12, 2025

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Feb 6, 2025 •
edited by slarticodefast
Loading

About the PR

Added a AP variant of the Mateba revolver which comes preloaded with AP (simular to the python) for deathsquad agents.

Why / Balance

Deathsquad agents come with a extra two AP speedloaders, yet for some reason their revolver was loaded with standard rounds instead of AP rounds.

Technical details

Added a child of WeaponRevolverMateba with AP rounds in it, and added the new WeaponRevolverMatebaAP to deathsquad's starting equipment.

Requirements

Changelog
🆑 Nox38

  • fix: Deathsquad agents Matebas now come loaded with AP rounds.

@Nox38 Nox38 changed the title Deathsquad Mateba ammo fix Deathsquad revolver ammo fix Feb 6, 2025
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/S Denotes a PR that changes 10-99 lines. labels Feb 6, 2025
@Nox38 Nox38 marked this pull request as ready for review February 6, 2025 00:20
@Nox38 Nox38 mentioned this pull request Feb 6, 2025
Open
2 tasks
ArtisticRoomba
ArtisticRoomba approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Combat Area: Combat features and changes, balancing, feel A: Command Area: Command department, where it isn't applicable to other departments. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
@slarticodefast slarticodefast self-assigned this Feb 11, 2025
@slarticodefast slarticodefast added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Feb 11, 2025
@Nox38
Copy link
Contributor Author

Nox38 commented Feb 11, 2025

done

@Nox38
Copy link
Contributor Author

Nox38 commented Feb 11, 2025

Should be all good? Sorry about that

slarticodefast
slarticodefast approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution!

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Feb 11, 2025
beck-thompson
beck-thompson approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@beck-thompson beck-thompson merged commit 129bcdf into space-wizards:master Feb 12, 2025
12 checks passed
@Nox38 Nox38 deleted the Mateba-AP branch February 13, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

@ArtisticRoomba ArtisticRoomba ArtisticRoomba approved these changes

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: Combat Area: Combat features and changes, balancing, feel A: Command Area: Command department, where it isn't applicable to other departments. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nox38 @beck-thompson @ArtisticRoomba @slarticodefast