Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Ability to Cycle the Light Replacer #34891

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

southbridge-fur
Copy link
Contributor

About the PR

With many different lights that exist in the game, it can be a bit inconvenient to remove lights you don't want to use from the light replacer. Especially when you get a pack of colored lights, but only want to use regular ones, or are trying to single out the right lights for the job.

This PR helps improve the experience of janitors everywhere by making it easy to remove lights from the light replacer, by dumping them on the floor.

Why / Balance

QoL mostly.

Technical details

Added new sound specifiers to the light replacer and light bulb components.

In LightReplacerComponent.cs

[DataField]
public SoundSpecifier CycleSound = new SoundPathSpecifier("/Audio/Weapons/Guns/Cock/smg_cock.ogg");

In LightBulbComponent.cs

[DataField]
public SoundSpecifier DropSound = new SoundCollectionSpecifier("GlassCrack", AudioParams.Default.WithVolume(-6f));

Subscribed the LightReplacerSystem to the UseInHandEvent which when fired activates the new method HandleUseInHand which will attempt to eject a bulb onto the ground.


Also added a new loc string for the eject action.

Media

light-replacer-cycle.mp4

Requirements

Breaking changes

Changelog

🆑 Southbridge

  • add: Light Replacers can now be cycled to empty bulbs onto the floor.

@southbridge-fur southbridge-fur changed the title Added the Ability to Cycle the Light Replacer. Added the Ability to Cycle the Light Replacer Feb 5, 2025
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Feb 5, 2025
@lzk228
Copy link
Contributor

lzk228 commented Feb 5, 2025

the main idea of light replacer is "storage from which lamps cannot be removed"

@southbridge-fur
Copy link
Contributor Author

southbridge-fur commented Feb 5, 2025

the main idea of light replacer is "storage from which lamps cannot be removed"

Lamps can be removed though, through the very annoying process of filling a light fixture, pulling the light out, putting another one in, and so on. This just gives us some quality of life.

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Service Area: Service department, including cooking, botany, etc and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Service Area: Service department, including cooking, botany, etc D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants