Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dehardcoded Space Heaters UI window title #34884

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Dehardcoded Space Heaters UI window title #34884

merged 1 commit into from
Feb 4, 2025

Conversation

Menshin
Copy link
Contributor

@Menshin Menshin commented Feb 4, 2025

About the PR

Apparently needed, so changed the space heater/TCU UI window title i previously hardcoded to a locale var.
Feel free to ask for others changes.

Closes #34665.

Requirements

Changelog
Not needed, not player facing.

@Menshin Menshin requested a review from Partmedia as a code owner February 4, 2025 21:53
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. S: Needs Review Status: Requires additional reviews before being fully accepted Changes: UI Changes: Might require knowledge of UI design or code. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Feb 4, 2025
MilonPL
MilonPL approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, looks good to me, thank you for your contribution!

@MilonPL MilonPL self-assigned this Feb 4, 2025
@MilonPL MilonPL added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Feb 4, 2025
slarticodefast
slarticodefast approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@slarticodefast slarticodefast merged commit 5af55bb into space-wizards:master Feb 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

@MilonPL MilonPL MilonPL approved these changes

@Partmedia Partmedia Awaiting requested review from Partmedia Partmedia is a code owner

Assignees

@MilonPL MilonPL

Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: UI Changes: Might require knowledge of UI design or code. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

space window heater title is hardcoded
3 participants
@Menshin @MilonPL @slarticodefast