MindRemoveRole refactor #34880
MindRemoveRole refactor #34880
Conversation
github-actions
bot
added
S: Untriaged
Errant-4
added
P3: Standard
github-actions
bot
added
the
S: Needs Review
|
Who dares summon me? |
| /// <param name="mind">The mind entity and component</param> | ||
| /// /// <param name="protoId">The prototype ID of the mind role to be removed</param> | ||
| /// <returns>True if the role existed and was removed</returns> | ||
| public bool MindRemoveRole(Entity<MindComponent?> mind, EntProtoId<MindRoleComponent> protoId) |
There was a problem hiding this comment.
I'm not sure if removing components depending on a prototype is the right approach. Usually we don't want prototypes to be used for anything other than spawning entities.
What is the usecase you will need this for?
There was a problem hiding this comment.
Specifying a temporary mindrole by datafield.
Specific usecase is making a brain/pAI insertable into a borg ((whether this is a desired feature is not relevant for the purposes of functionality)). It must get the Silicon mindrole when put into a borg, and lose it when removed. The most straightforward way for this is to specify the prototypeID in yaml, and use it both for adding and removal.
The alternative would be to store some type of "termination tag/identifier" on each MindRoleComponent, then you would have to Index the prototypeID supplied for creation, read it's MindRoleComponent, and search the target's mind role entities for that, and remove. That was how I was first going to do it, but it seems needlessly complicated
There was a problem hiding this comment.
Using prototypes for this looks still a little sus, but the idea makes sense.
We best ask sloth if he can think of a different approach.
There was a problem hiding this comment.
My backup idea would be to use Tags, but then I would have to make a bunch of tags, seems like a waste of time and space
About the PR
Reorganised MindRemoveRole and it's overloads. Mind roles can now be removed based on prototypeId
Why / Balance
Need this for an upcoming PR.
Until now, it was only possible to remove them by specifying a component. Now the same data that can create them can also remove them.
Technical details
MindRemoveRole can now be called without , instead specifying a protoId as the second parameter.
Both the old and the new version runs their own foreach on the mind's roles, and creates a deletion list. They then call the new MindRemoveRoleDo(), which contains parts of the code that could be shared between the different versions.
The
Foundvariable which was used to mark that deletable entities were found has been removed, in favor of simply checking if the Delete list contains any elements.Requirements
Breaking changes
MindTryRemoveRole() was replaced with an overload of MindRemoveRole(). Simply remove "Try" from every existing use, and it will work.
Changelog
No player or admin facing changes.