-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make hacking energy swords predicted #34877
Make hacking energy swords predicted #34877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Content.Shared/Weapons/Melee/EnergySword/EnergySwordComponent.cs
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
i retract my previous statments, they have been banned from everything but the repo and the review was done by a new hire unrelated. its moreso suprising that they are even making PRs anymore after the whole ordeal. i assumed the worst when i shouldnt have tbh. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Anyways enough of this.
Now please stop spamming the repo with this. Edit: Yes for anyone asking they were banned now. |
About the PR
Pulsing an energy sword with a multitool to change its color is now predicted
Why / Balance
I'm just looking for stuff to make predicted
Technical details
Entity<T> entity
formatMedia
Before:
2025-02-04.08-14-35.mp4
After:
2025-02-04.08-25-45.mp4
Requirements
Breaking changes
EnergySwordComponent and EnergySwordSystem moved from Content.Server to Content.Shared
EnergySwordSystem functions updated to use the
Entity<T>
format