Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hacking energy swords predicted #34877

Merged

Conversation

Plykiya
Copy link

@Plykiya Plykiya commented Feb 4, 2025

About the PR

Pulsing an energy sword with a multitool to change its color is now predicted

Why / Balance

I'm just looking for stuff to make predicted

Technical details

  • Moved the Component and System to Content.Shared
  • Added NetworkedComponent and AutoGenerateComponentState to to the EnergySwordComponent
  • Added AutoNetworkedField to the ActivatedColor and Hacked datafields
  • Updated EnergySwordSystem to use the Entity<T> entity format
  • Added a dirty call at the end of the InteractUsing handler to update the energy sword after changes

Media

Before:

2025-02-04.08-14-35.mp4

After:

2025-02-04.08-25-45.mp4

Requirements

Breaking changes

EnergySwordComponent and EnergySwordSystem moved from Content.Server to Content.Shared
EnergySwordSystem functions updated to use the Entity<T> format

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. labels Feb 4, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Feb 4, 2025
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Feb 4, 2025
@slarticodefast slarticodefast self-assigned this Feb 4, 2025
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: Refactor Type: Refactor of notable amount of codebase D3: Low Difficulty: Some codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 5, 2025
@MilonPL MilonPL merged commit 0d9f9e9 into space-wizards:master Feb 5, 2025
12 checks passed
@Plykiya Plykiya deleted the energy-sword-hacking-predicted branch February 5, 2025 20:10
@Skyesek

This comment was marked as off-topic.

@a-person5660

This comment was marked as off-topic.

@AveriV2

This comment was marked as off-topic.

@a-person5660

This comment was marked as off-topic.

@AveriV2

This comment was marked as off-topic.

@a-person5660

This comment was marked as off-topic.

@a-person5660
Copy link

a-person5660 commented Feb 5, 2025

i retract my previous statments, they have been banned from everything but the repo and the review was done by a new hire unrelated. its moreso suprising that they are even making PRs anymore after the whole ordeal. i assumed the worst when i shouldnt have tbh.

@ARMOKS

This comment was marked as off-topic.

@lanse12

This comment was marked as off-topic.

@a-person5660

This comment was marked as off-topic.

@space-wizards space-wizards locked as too heated and limited conversation to collaborators Feb 5, 2025
@space-wizards space-wizards unlocked this conversation Feb 5, 2025
@ARMOKS

This comment was marked as off-topic.

@nikthechampiongr
Copy link
Contributor

nikthechampiongr commented Feb 5, 2025

Anyways enough of this.

  1. They were never repobanned and as such we could not have unbanned them, I don't know where you all got this from. We usually don't bother to repoban people unless they fuck around in the github as its moderation tools are horrible. We did not expect them to make a PR either.
  2. The PR was reviewed quickly because it is very simple(it moved 2 files from Server to Shared). Claims of favoritism are unfounded considering this PR was reviewed by a maintainer who became a maintainer yesterday and had no idea who this person is.

Now please stop spamming the repo with this.

Edit: Yes for anyone asking they were banned now.

@space-wizards space-wizards locked as too heated and limited conversation to collaborators Feb 5, 2025
@space-wizards space-wizards deleted a comment from lanse12 Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Refactor Type: Refactor of notable amount of codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.