Add support for unshaded displacement maps #34876
Open
+41
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Made a couple tiny changes to DisplacementMapSystem & DisplacementData to allow displacements to propely be applied to unshaded layers on a sprite.
Why / Balance
It's a small thing that's been annoying the artists on the fork I play on + it seems a few people have been talking about it in the main wizden discord.
Technical details
Added the DisplacedStencilDrawUnshaded shader, a copy of DisplacedStencilDraw with light_mode set to unshaded.
Added the ShaderOverrideUnshded field to DisplacementData that points to the new shader.
Added a check to DisplacementMapSystem to use the new shader if the original layer was unshaded.
To use it, all you need to do is specify an unshaded layer in the clothingComponent, like so
Media
old (left) & new (right), using the above example clothing comp
Requirements
Changelog
no CL; not player-facing enough?