Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paper door #34857

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Paper door #34857

merged 4 commits into from
Feb 8, 2025

Conversation

Chaboricks
Copy link
Contributor

About the PR

Replacement of the sound of paper doors. Now they have the sound of metal doors. Issue #34806

Why / Balance

Doors are now subject to logic.

Technical details

Added new .ogg file.

Media

Sound

Requirements

Breaking changes

Changelog

🆑

  • tweak: Changed the sound of paper doors.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Audio Changes: Might require knowledge of audio. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Feb 3, 2025
@slarticodefast
Copy link
Member

By the way, you don't have to make a new PR if you want to make changes. You can simply push a new commit to your remote branch an the PR will update automatically.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Feb 3, 2025
slarticodefast
slarticodefast approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!
Thank you for your contribution!

@slarticodefast slarticodefast self-assigned this Feb 3, 2025
@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Feb 3, 2025
@chromiumboy
Copy link
Contributor

We can make doors out of paper?

But, why? O.o

@slarticodefast
Copy link
Member

We can make doors out of paper?

It's a japanese style sliding door.

beck-thompson
beck-thompson approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds a lot better!

@beck-thompson beck-thompson merged commit 1caea8a into space-wizards:master Feb 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
Changes: Audio Changes: Might require knowledge of audio. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chaboricks @slarticodefast @chromiumboy @beck-thompson