Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new complex armor component, tweaks for CE hardsuit #34853

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kosticia
Copy link
Contributor

@kosticia kosticia commented Feb 3, 2025

About the PR

Added new component that provides resist to the damage when clothing with this component being worn with specific item

Why / Balance

More ways to manage damage resist. Thats cool.

Requirements

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Feb 3, 2025
@KaiserMaus
Copy link

100% a feature of the CE hardsuit, since Chief Engi can work with the singularity without fear, this is also the unofficial goal of the agent when stealing the Plutonium Core, of course you can take other spacesuits or medicine from radiation, but this will not save for long

@MozarteanChaos
Copy link

100% a feature of the CE hardsuit, since Chief Engi can work with the singularity without fear, this is also the unofficial goal of the agent when stealing the Plutonium Core, of course you can take other spacesuits or medicine from radiation, but this will not save for long

the base CE hardsuit already has 100% radiation resistance, the helmet doesn't need more radiation resistance

@MozarteanChaos
Copy link

MozarteanChaos commented Feb 3, 2025

actually, wait, this PR just adds resistances to the CE helmet... the helmet didn't have any resistances in the first place, including radiation resistance. are you sure you're PRing this to the right place?

@MozarteanChaos
Copy link

MozarteanChaos commented Feb 3, 2025

actually, wait, this PR just adds resistances to the CE helmet... the helmet didn't have any resistances in the first place, including radiation resistance. are you sure you're PRing this to the right place?

i have been informed that it inherits its resistances from ClothingHeadHardsuitBase, which for some reason has - among other things - 75% radiation resistance by default.
this baffles and vexes me. however, it does also remove the problem i had with this PR.

@slarticodefast
Copy link
Member

Since it does not change the stats at all I don't really see the need for this. It only adds extra yaml code.

@VerinSenpai
Copy link
Contributor

Honestly I feel like the suit should provide like 75 and 100 with the helmet

@ArtisticRoomba
Copy link
Contributor

The hardsuit should provide the bulk of the protection and the helmet bring it up to 100- we have flavor text for telling you to equip your helmet before doing stuff like this, however in practice it's actually unnecessary. This change should be made so it lines up with expected behavior.

@slarticodefast
Copy link
Member

Honestly I feel like the suit should provide like 75 and 100 with the helmet

Yeah, that makes sense. It should not give you full protection without the helmet.

@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Engineering Area: Engineering department, including Atmospherics. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 5, 2025
@kosticia kosticia marked this pull request as draft February 6, 2025 09:34
@kosticia
Copy link
Contributor Author

kosticia commented Feb 6, 2025

I have better idea...

@HelpTheSteak
Copy link

Honestly I feel like the suit should provide like 75 and 100 with the helmet

Yeah, that makes sense. It should not give you full protection without the helmet.

It would not be possible to have fully rad proof armor if you split them up. The resistances don't add up with eachother they take away damage separately so you would still take a very little amount of rad each second

@slarticodefast
Copy link
Member

It would not be possible to have fully rad proof armor if you split them up. The resistances don't add up with eachother they take away damage separately so you would still take a very little amount of rad each second

Pretty sure there was a bool changing it to be additive.

@deltanedas
Copy link
Contributor

helmet with 0 radiation coefficient makes it radiation proof

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 8, 2025
@kosticia kosticia changed the title Remove radiation resist from CE hardsuit helmet Add new complex armor component, tweaks for CE hardsuit Feb 8, 2025
@kosticia kosticia marked this pull request as ready for review February 8, 2025 16:12
@kosticia kosticia marked this pull request as draft March 28, 2025 17:19
@kosticia
Copy link
Contributor Author

Draft because it doesn't work for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Engineering Area: Engineering department, including Atmospherics. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants