Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Oasis evac timer #34849

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix Oasis evac timer #34849

merged 1 commit into from
Feb 4, 2025

Conversation

DinnerCalzone
Copy link
Contributor

@DinnerCalzone DinnerCalzone commented Feb 3, 2025 •
edited
Loading

About the PR

Makes Oasis' emergency shuttle transmit its ETA timer.

Why / Balance

Bugfix.

Technical details

Adds the DeviceNetwork component to emergency_accordia's grid with the appropriate settings for it to transmit its timer.

Media

Ye289o8

Requirements

Breaking changes

None.

No cl, small map-specific fix.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. size/XS Denotes a PR that changes 0-9 lines. labels Feb 3, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 3, 2025
@Emisse Emisse merged commit d9d451d into space-wizards:master Feb 4, 2025
14 checks passed
@DinnerCalzone DinnerCalzone deleted the evac-timer branch February 10, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DinnerCalzone @Emisse @ArtisticRoomba