Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General storage fixes #34845

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

General storage fixes #34845

wants to merge 4 commits into from
+144 −37

Conversation

metalgearsloth
Copy link
Contributor

@metalgearsloth metalgearsloth commented Feb 3, 2025 •
edited
Loading

Fixes #34780
Requires space-wizards/RobustToolbox#5650

  • Fix positions not saving.
  • Fix the 1-tick delay between parent and child storage UIs opening / closing.
  • Fix BackButton being visible sometimes when it shouldn't be.

No idea if this will be on stable for merge or not but cl is uhh yeah.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 3, 2025
@ArtisticRoomba ArtisticRoomba added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 3, 2025
@metalgearsloth
Fix some more storage bugs
7a5aa34 
- Fix positions not saving.
- Fix the 1-tick delay between parent and child storage UIs opening / closing.
- Fix BackButton being visible sometimes when it shouldn't be.
@metalgearsloth metalgearsloth changed the title Fix storage stars General storage fixes Feb 3, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Feb 3, 2025
@metalgearsloth metalgearsloth changed the base branch from master to stable February 3, 2025 09:54
@metalgearsloth metalgearsloth changed the base branch from stable to master February 3, 2025 09:54
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@metalgearsloth
Merge remote-tracking branch 'upstream/master' into 2025-03-03-storag…
0f3ab84 
…e-stars

# Conflicts:
#	Content.Client/UserInterface/Systems/Storage/StorageUIController.cs
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Feb 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Partmedia Partmedia Awaiting requested review from Partmedia

@TheShuEd TheShuEd Awaiting requested review from TheShuEd

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf

@Emisse Emisse Awaiting requested review from Emisse

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage ui v2 broke stars
2 participants
@metalgearsloth @ArtisticRoomba