Wizard Staff of Animation #34649
Merged
Wizard Staff of Animation #34649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
ArtisticRoomba
added
P3: Standard
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
S: Merge Conflict
github-actions
bot
added
the
S: Needs Review
ScarKy0
requested changes
Feb 7, 2025
|
Also the staff needs to have limited uses and all that jazz. |
ScarKy0
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adding Staff of Animation to Wizard. Permission from KeronSHB.
Why / Balance
Tweak the numbers as you see fit. This is just functionality. This is one of the spells/magic items KeronSHB wants.
I feel that it will need a significant amount of playtesting to determine what should/should not be animated.
Technical details
Added a blacklist to EntityTargetAction. Seems to work just fine. If no blacklist on EntityTargetAction then the UI won't properly reflect what is / isn't an available target unless somebody wants to tell me how to do it otherwise.
Added a Wizard NPC faction that the animate object is a part of.
Added an Animateable Component that determines what can / cannot be animated via EntityTargetAction whitelist. I was recommended to use a component over a tag.
Media
staffofanimation.mp4
Requirements