Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonioon mutation #33375

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Bonioon mutation #33375

wants to merge 7 commits into from

Conversation

Thinbug0
Copy link
Contributor

@Thinbug0 Thinbug0 commented Nov 17, 2024

About the PR

Added a new onion mutation, its produce are onion balloons which contain allicin and do a super minimal explosion when popped

Why / Balance

It's a silly mutation that helps the station with its lack of balloons, while still being something fitting for botany shenanigans. Specially silly for birthdays
The smol explosion gives them a bit more charm, to further differentiate them from regular balloons

Technical details

Well so had to make them a structure to get them to collide with projectiles because guh no way i was adding balloons that dont get popped by darts

Media

showdraft
Smol silly showcase thingi
https://youtu.be/FlEam5lrdII

Requirements

Breaking changes

Changelog

🆑

  • add: New onion mutation, Bonioons! floating balloon-like onions.

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/L Denotes a PR that changes 1000-4999 lines. labels Nov 17, 2024
@Thinbug0
Copy link
Contributor Author

guh guh i already did a whoopsie and left something as a comment that shouldnt be like that guh

Copy link
Contributor

github-actions bot commented Nov 17, 2024

RSI Diff Bot; head commit 55391ef merging into 647db6a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Hydroponics/bonioon.rsi

State Old New Status
dead Added
harvest Added
produce-inhand-left Added
produce-inhand-right Added
produce Added
seed Added
stage-1 Added
stage-2 Added
stage-3 Added
stage-4 Added

Edit: diff updated after 55391ef

@Thinbug0
Copy link
Contributor Author

guh i also forgor to put the copyrigth thingi gmmhhmh ang ery

@muburu
Copy link
Contributor

muburu commented Nov 17, 2024

bloonion sounds funnier

also it'd be funny if they had a tear gas effect when exploding because onion make cry

@Thinbug0
Copy link
Contributor Author

Thinbug0 commented Nov 18, 2024

bloonion sounds funnier

also it'd be funny if they had a tear gas effect when exploding because onion make cry

ohh frealsies thats a goodie name, may change it to that later :33
thankies

and the tear gas would be a tad too annoying imo, tho maybe could replace the allicin with that

@Doru991
Copy link
Contributor

Doru991 commented Nov 18, 2024

okay hear me out: what if when popping, instead of an explosion with tear gas or anything specific they just released smoke containing their reagents
surely nothing wrong could come out of that :^)

@ArtisticRoomba
Copy link
Contributor

okay hear me out: what if when popping, instead of an explosion with tear gas or anything specific they just released smoke containing their reagents surely nothing wrong could come out of that :^)

would be a little too op considering any robust botanist can roll for amatoxin or space lube and RR anyone

@Thinbug0
Copy link
Contributor Author

Thinbug0 commented Nov 18, 2024

yeah they are meant to be silly party stuff, something you could safely fill a room with
(for context the explosion is basically the same as the snap pops, slightly higher so they will pop each other)

@thebadman4662
Copy link

thebadman4662 commented Nov 18, 2024

yeah they are meant to be silly party stuff, something you could safely fill a room with (for context the explosion is basically the same as the snap pops, slightly higher so they will pop each other)

So high enough to grief doctors by throwing them and spill reagents in bottles in their backpacks and belts. :trollface:

@Thinbug0
Copy link
Contributor Author

oki so like, whole them being an item and a structure thingi done, they can pop when hit by darts, still gotta fix some sillies like an offset on the fixture

@Thinbug0 Thinbug0 changed the title Boonion draft Bonioon mutation Nov 19, 2024
@Thinbug0 Thinbug0 marked this pull request as ready for review November 19, 2024 03:03
@Thinbug0
Copy link
Contributor Author

of course yeah oki gonna check that gosh angery grrrrrrr

@Thinbug0
Copy link
Contributor Author

me whem i confuse a b for a B, twice

@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 19, 2024
@beck-thompson beck-thompson added the A: Service Area: Service department, including cooking, botany, etc label Nov 19, 2024
@IProduceWidgets
Copy link
Contributor

am I missing something? Did this stop working? #30088

@Thinbug0
Copy link
Contributor Author

Thinbug0 commented Nov 19, 2024

am I missing something? Did this stop working? #30088

whoopsie i missed that, tho it only works when people are holding the balloon since they dont have like fixtures for stuffies to collide with them

still good catch, ill give them the balloon tag
(idk why the heck github added a random number to my comment guh, removed it)

@Thinbug0
Copy link
Contributor Author

actually it works by straight up deleting the entity so im gonna deal with this later, would be wacky as heck for this to be the only scenario where they dont go boom and dont splash stuff -v-

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted size/L Denotes a PR that changes 1000-4999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants