-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification sound to headsets #32936
Conversation
here's a previous PR that was trying to do a similar thing 30780 |
So... I made what they wanted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in game, works works great! Maybe some variety on the radio noise would be nice but that's pretty minor.
The only issue I found was that you can right click someone elses headset and see the channels that are stored on it. Security will metagame thieves/syndicates a lot with this so you should probably change it so you can only change channels if its on your head or the ground (Anytime you could inspect it basically).
Very cool code, definitely needs to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some minor stuff, rest looks good to me!
Needs final test because I didn't compile it after last fix. |
You're an absolute star, thank you. This feature helps people with visual impairments infinitely. |
Bold text is an inadequate indicator of a selected option, IMO. Far too difficult to differentiate, and may be even worse in other languages. Maybe give them a checkmark icon? |
code approve |
Are borgs or other entities with intrinsic radio able to set the notification sound as well? |
Maybe later. We can add to them headset slot with not unequippable headset.
But if you are passenger and you find command's headset, you want it to be configured as command headset. Also there will be a need to define default sound channels for each role. I think it's bad. |
I believe you would just have 'Command' notifications enabled before you even get your hands on the privileged headset, along with all other department channels. This would only be annoying for Captain. |
Maybe I should use |
i mean it seems good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor change! Looks good besides this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Its under maintainer discussion now 🫡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Sorry for the long wait on this PR. There was a lot of debate on this but it was eventually decided that it would be better to have the notification sound be a chat menu setting rather than a setting on the headset itself. This is mainly because there are many situations where you would want notifications but dont have a headset, e.g if your a borg, or a holoparasite (Forks have even more examples as well). This will probably become a even bigger issue after the incoming chat refactor is finished!
There are some PRs up for chat highlighting, and adding a menu for notification sounds should be somewhat similar (UI wise at least)!
If you need any help or have questions just ask here or the discord
About the PR
Add notification sound to headset when it receives radio message.
You can configure with RBM which channels will emit sound and which not.
On regular headsets there are all channels except common by default. On centcom and command headsets enabled only it's channels and syndicate.
Bold font on verbs is used to mark channel as channel with enabled sound.
Why / Balance
Without notification sound you can easily miss important message.
If you don't want this feature you can set all channels to off.
Technical details
Added verbs to headsets.
Added fields to HeadsetComponent.
Added VerbCategory.
Changed headset prototypes.
Added sound emitting to headset.
Added new sounds.
Added new sound collection.
Media
Requirements
Breaking changes
None
Authors
@FireNameFN (Discord: fntech) - idea and code.
@Komti23 (Discord: komti23) - sounds.
Changelog
🆑 FireNameFN, Komti23