Changelings #30094
Changelings #30094
Conversation
github-actions
bot
added
the
Changes: Sprites
|
RSI Diff Bot; head commit 5a3a30e merging into 7244b9b Resources/Textures/Changeling/Guidebook/guidebook_changeling.rsi
Resources/Textures/Changeling/arm_blade.rsi
Resources/Textures/Changeling/bone_shard.rsi
Resources/Textures/Changeling/changeling_abilities.rsi
Resources/Textures/Changeling/changeling_biomass.rsi
Resources/Textures/Changeling/changeling_chemicals.rsi
Resources/Textures/Changeling/ling_armor.rsi
Resources/Textures/Changeling/ling_armor_helmet.rsi
Resources/Textures/Changeling/ling_spacesuit.rsi
Resources/Textures/Changeling/ling_spacesuit_helmet.rsi
Resources/Textures/Changeling/shields.rsi
Resources/Textures/Interface/Misc/job_icons.rsi
|
|
forgot to port the gamerule my bad og |
github-actions
bot
added
the
S: Needs Review
|
@ARMOKS you can pull up w/ the design doc here ❤️ |
|
Hooray, I hope you fixed the slow chem regen. true (shitcode |
hope dies last |
|
armok made a doc? can someone reply me the pr? |
There was a problem hiding this comment.
- Please read through https://docs.spacestation14.com/en/general-development/codebase-info/conventions.html?highlight=conventions#conventions
- Almost all of this code is hardcoded to changelings and not generic.
- While goobstation may not care about asset licensing we do.
metalgearsloth
added
S: Awaiting Changes
|
that's great but where does my code start being non-conventional?
it makes sense because changelings are kinda not supposed to be generic, because every ability requires chemicals and if you're not a changeling you're not supposed to use them, exception being an omnitraitor but it's easily mitigatable by simply adding a changeling component. methods are also are made as generic as possible i can't go any farther beyond making a million methods to do a single thing, it's just dumb imo.
my bad og, forgot to reference a couple things, i'll do it tomorrow or sth |
|
hope dies last 😔 |
|
Can you make a radial menu for transformation? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
sure, i'll try 👍 |
|
Good luck with that |
This comment was marked as abuse.
This comment was marked as abuse.
apologies for having standards. we should clearly just allow whatever code people submit because it's "cool." That has clearly never caused issues before in the past (disease, vehicles, executions, nukies)
i know it's hard to pull your head out from your own ass but i think you'll get there one day. keep working at it.
lol |
|
we arent getting lings sadge
oniks you are cool and all, but idk if taking that here would be good. all you though gng. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as abuse.
This comment was marked as abuse.
alrighty, ye be the boss |
|
"can't you just do <thing that may take a long while to complete> in 5 seconds the instant it becomes possible" |
Formally, this is a fairly simple system, all you need to do is write controls similar to the shuttle, and also remove these unnecessary components and use connection checking. |
|
|
||
| return true; | ||
| } | ||
| public bool TryToggleItem(EntityUid uid, EntProtoId proto, ChangelingComponent comp, string? clothingSlot = null) |
There was a problem hiding this comment.
I will be very glad if you make a separate system for this that can be used not only for changeling.
At the very least, I need it for the cult of flesh and also for the IPC charging module.
|
forgot to port client side changes, now biomass and chemicals should render properly 😅 |
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
a new batch of bugs got spammed into my DMs (again), expect update rolling out soon enough also new design doc is out, i can make it real 😄, it's just that i don't want to say byebye to all the abilities that are there already. suggestions? |
Please bring your case to the end. I want this antagonist to appear in our favorite game |
when you say "I don't want to say byebye to all the abilities" does that mean they are going to be removed or reworked? |
removed to match the design doc |
|
How closely do you have to follow the design doc? Because the doc mentions that virology/surgery would have to be added before changelings due to the eye spiders inflicting a special disease. I was wondering if you could just use chems instead (for example ambuzol stopping zombie virus), That way you are not waiting on a update to add viro/surgery and you can just get changelings out the door. |
good question. that's why i'm asking if i'll have to remove most of ling's abilities that already exist |
|
so uh, how's changelings pr, what now? |
|
For now, we wait until he adds new stuff (hopefully) or reviewers get around to checking the PR. |
There was a problem hiding this comment.
Needs predicting.
After having coded AI I have a better idea of what needs doing. For starters all of the stings being hardcoded reagents is bad. These should just be components stored on the ling itself or on an action entity.
Another if you have actions applying component changes when we already have functionality to do this entirely in yaml via compregistry.
Once you've done the above we'll go from there.
metalgearsloth
added
S: Awaiting Changes
ok cool. where can i find an example of that so that i can work my way up from there? |
|
btw while i'm working on heretics this repo will be put on hold |
compregistry = As you can see, these components from To find more examples, search for: |
|
are you going to keep the hunger system? your pr has been merged in one of the servers and from my experience it results in changelings slaughtering a lot of people, as every single changeling has to consume someone every 20-25 minutes |
it's in the design doc so yes |
I feel like it should be every 26 mins or so, but I feel like the point of a changeling is to consume alot and to be a very active and more threatening then syndicates, that way it puts pressure on the crew and on security to catch them. |
|
can't bring myself to refactor it, heck can't even bring myself to actually do any coding. feel free to use this pr in any way you want, i'm out. |
I feel that ❤️ |
About the PR
Added changelings, based on Paradise Station wiki entry with a bit of this design doc. They have their differences but they're mostly the same.
With custom objectives to make them somewhat different from a tot.
Objectives:
Some can say they're entirely based on round removal.
Absorption gives you bonus evolution points and increases the maximum amount of chemicals. Absorbing another changeling gives you half of it's max chemicals, biomass and evolution points.
Why / Balance
EDIT: thank god someone made an actually approved and merged design doc for clings ™️
Technical details
shitcode!! need 3000 refactors and 1984 comments
Media
Since i for some reason can't build it because of some git pull robust toolbox clustershit I'm showing media taken from Goobstation, where changelings were playtested before PRing it to wizden.
Basic abilities, objectives, blabla
if icons ever tell you anything
Gaming setup (space adaptation + armblade + shield)
Breaking changes
none i believe.
TODO
NEW TODO:
NEW NEW TODO:
All of the mechanics are fully implemented so this can be copied/merged and happily used.
Downstream maintainers go crazy ❤️😔
Changelog
🆑