fix(JitteringSystem): Fix warnings and double Play. #30085
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some warnings within the Jitter system and ensure we're not playing a jitter animation before playing another animation thus throwing an exception. Saw an exception in live within OnStartup of JitteringSystem.
Comment on lines
+56
to
+59
| if (HasComp<AnimationPlayerComponent>(uid) | ||
| && TryComp(uid, out SpriteComponent? sprite) | ||
| && !_animationPlayer.HasRunningAnimation(uid, _jitterAnimationKey)) | ||
| _animationPlayer.Play(uid, GetAnimation(jittering, sprite), _jitterAnimationKey); |
There was a problem hiding this comment.
Shouldn't the animation player be passed in here still?
There was a problem hiding this comment.
No, there are Play functions that do but they're deprecated.
There was a problem hiding this comment.
I see one that takes in Entity that looks suitable.
There was a problem hiding this comment.
Isn't that the uid in arg0? Or am I missing something here.
There was a problem hiding this comment.
I'm using public void Play(EntityUid uid, Animation animation, string key) which basically calls Play the same way in this case, except I guess we could drop the HasComp check if I use it the way as it is in this PR.
metalgearsloth
added
the
S: Awaiting Changes
SlamBamActionman
added
the
S: Untriaged
eoineoineoin
added
T: Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fix some warnings within the Jitter system and ensure we're not playing a jitter animation before playing another animation thus throwing an exception. Saw an exception in live within OnStartup of JitteringSystem.
Media