Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem #30084

Merged

Conversation

Cojoke-dot
Copy link
Contributor

About the PR

Replace all references of SolutionContainerSystem with the 'SharedSolutionContainerSystem'

Why / Balance

0 warnings, SolutionContainerSystem is obsolete

Technical details

Replace SolutionContainerSystem with the 'SharedSolutionContainerSystem' and fix any errors that pop up

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Holy shit I should have split this up into more prs, no cl

@Cojoke-dot Cojoke-dot marked this pull request as ready for review July 16, 2024 05:26
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted labels Jul 16, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 19, 2024
@Chief-Engineer Chief-Engineer removed their request for review July 19, 2024 03:08
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Jul 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Jul 30, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Aug 6, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 2, 2024
@PJB3005 PJB3005 merged commit ef1fadf into space-wizards:master Sep 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants