Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge unknown shuttle rules into one rule #30065

Closed
wants to merge 3 commits into from

Conversation

lzk228
Copy link
Contributor

@lzk228 lzk228 commented Jul 15, 2024

About the PR

instead of different rules, there is just one, that will select random shuttles from the list
along with datafield in LoadMapRuleComponent was changed to the list to support randomness

Why / Balance

fixes #28209 fixes #29087

Technical details

Media

2024-07-15_13-33-14.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Fixed unknown shuttle gamerule appearing too often

@lzk228 lzk228 requested a review from EmoGarbage404 as a code owner July 15, 2024 11:28
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jul 15, 2024
@TurboTrackerss14
Copy link
Contributor

So while this is nice for normal round progression.
It would be nice to still be able to select exactly which unknownshuttle spawns as an admin running an event

be admin running syndicate announcements from distance syndicate station
spawn 2-3 unknown shuttle syndicate survivors.
lore

This wouldn't be possible via a simple gamerule command and would need a fair amount more setup.

@deltanedas
Copy link
Contributor

said setup just being loadgrid command

@TurboTrackerss14
Copy link
Contributor

TurboTrackerss14 commented Jul 15, 2024

said setup just being loadgrid command

Which isn't logged like addgamerule, which appears to any admins that connect.

@TheShuEd
Copy link
Member

This has already been discussed, here we need another solution, unified with the Secret gamemode rule. a rule that allows you to run one of the sub-rules based on weights

@TheShuEd TheShuEd closed this Jul 15, 2024
@IProduceWidgets
Copy link
Contributor

[#29320] currently waiting on this to merge for the same reasons.

@lzk228 lzk228 deleted the 07-15-uknownshuttle-fix branch August 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evac is blocked by shuttles way too often unknown shuttle rules should probably be a single rule
5 participants