Make every button in the lobby menu toggable and close windows #30059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Changes: UI
Winkarst-cpu
changed the title
Winkarst-cpu
changed the title
Winkarst-cpu
changed the title
Winkarst-cpu
changed the title
SlamBamActionman
added
the
S: Untriaged
|
Are you going to come back to this? Would be good if you could fix #30059, too, since it's so related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Made every button in the lobby menu toggable, and also made all windows close when the lobby menu is closed (except the AHelp window).
Why / Balance
Fixes #29450, fixes #28855. It's much better to make each button toggable and close all windows when the lobby menu is closed.
Technical details
Made every button in the lobby menu to have
ToggleModeset to true, and added code to close windows when the lobby menu is closed.Media
2024-07-15.09-54-22.mp4
2024-07-15.09-47-00.mp4
Breaking changes
Changelog
🆑