Better Inventory Window Positioning #30058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I just reimplemented how StaticStorage positions the window but my way allows it to get moved around the screen, sigh... apparently StaticStorage needs to be removed from the StorageUIController anyways so... I guess that's nice |
SlamBamActionman
added
the
S: Untriaged
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
S: Merge Conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
When the user has that one bag locked position setting turned off, currently the bag will open in the same spot based off of the top left corner of the window.
I updated the behavior for both the X axis and the Y axis.
Why / Balance
When you have bags that are of extremely different sizes, the experience is quite poor. This is especially noticeable when you go from something tiny like a survival box to something massive like a bag of holding. Your window will be completely askew from where you would expect the "middle" of the window to be.
Technical details
I think the math is pretty simple, I added comments and overly obvious variable names. The only issue at the moment is that Storage UI prediction is making the experience super jank, but this is what I would want the math to be once Storage UI prediction gets fixed.
#27637
Media
Before:
2024-07-14.21-39-36.mp4
After:
2024-07-14.21-55-04.mp4
Breaking changes
Changelog
🆑